Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: session and accounts cleanup #36

Merged
merged 3 commits into from
Dec 16, 2024
Merged

chore: session and accounts cleanup #36

merged 3 commits into from
Dec 16, 2024

Conversation

skibitsky
Copy link
Member

@skibitsky skibitsky commented Dec 14, 2024 •
edited
Loading

  • Convert SessionStruct structure to Session class for better performance
  • Consolidate duplicate types representing CAIP-10 accounts into a single immutable Account structure
  • Fix confusing terminology around accounts. Now AddressProvider, Session and Utils reference use Account or Account ID term for CAIP-10's account_id, and Address for account_address (e.g. Ethereum 0x address)
  • Add optimised utility method for Account ID deconstruction into Chain ID and Address

@skibitsky skibitsky requested a review from jakubuid December 14, 2024 11:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2024 •
edited
Loading

Deploy preview for unity-appkit ready!

✅ Preview
https://unity-appkit-21y4az2mi-reown-com.vercel.app

Built with commit 7482f14.
This pull request is being automatically deployed with vercel-action

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
50 New issues
0 Accepted issues

Measures
0 Security Hotspots
63.3% Coverage on New Code
2.2% Duplication on New Code

See analysis details on SonarQube Cloud

@skibitsky skibitsky merged commit 554c61c into main Dec 16, 2024
18 of 19 checks passed
@skibitsky skibitsky deleted the chore/session-cleanup branch December 16, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubuid jakubuid Awaiting requested review from jakubuid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skibitsky