Merge pull request #31 from reown-com/feate/raw-message

feat: raw message signing
reown-com · Dec 13, 2024 · 54da76f · 54da76f
2 parents c15ee18 + d97366a
commit 54da76f
Show file tree

Hide file tree

Showing 7 changed files with 47 additions and 0 deletions.
diff --git a/sample/Reown.AppKit.Unity/Assets/Scripts/Dapp.cs b/sample/Reown.AppKit.Unity/Assets/Scripts/Dapp.cs
@@ -215,6 +215,11 @@ public async void OnPersonalSignButton()
                 var account = await AppKit.GetAccountAsync();
 
                 const string message = "Hello from Unity!";
+
+                // It's also possible to sign a message as a byte array
+                // var messageBytes = System.Text.Encoding.UTF8.GetBytes(message);
+                // var signature = await AppKit.Evm.SignMessageAsync(messageBytes);
+
                 var signature = await AppKit.Evm.SignMessageAsync(message);
                 var isValid = await AppKit.Evm.VerifyMessageSignatureAsync(account.Address, message, signature);
 

diff --git a/src/Reown.AppKit.Unity/Runtime/Evm/EvmService.cs b/src/Reown.AppKit.Unity/Runtime/Evm/EvmService.cs
@@ -33,6 +33,14 @@ public Task<string> SignMessageAsync(string message)
             return SignMessageAsyncCore(message);
         }
 
+        public Task<string> SignMessageAsync(byte[] rawMessage)
+        {
+            if (rawMessage == null || rawMessage.Length == 0)
+                throw new ArgumentNullException(nameof(rawMessage));
+
+            return SignMessageAsyncCore(rawMessage);
+        }
+
 
         // -- Sign Typed Data ------------------------------------------
 
@@ -157,6 +165,7 @@ public Task<BigInteger> GetGasPriceAsync()
         protected abstract Task InitializeAsyncCore(SignClientUnity signClient);
         protected abstract Task<BigInteger> GetBalanceAsyncCore(string address);
         protected abstract Task<string> SignMessageAsyncCore(string message);
+        protected abstract Task<string> SignMessageAsyncCore(byte[] rawMessage);
         protected abstract Task<bool> VerifyMessageSignatureAsyncCore(string address, string message, string signature);
         protected abstract Task<string> SignTypedDataAsyncCore(string dataJson);
         protected abstract Task<bool> VerifyTypedDataSignatureAsyncCore(string address, string dataJson, string signature);

diff --git a/src/Reown.AppKit.Unity/Runtime/Evm/NethereumEvmService.cs b/src/Reown.AppKit.Unity/Runtime/Evm/NethereumEvmService.cs
@@ -101,6 +101,12 @@ protected override async Task<string> SignMessageAsyncCore(string message)
             return await Web3.Client.SendRequestAsync<string>("personal_sign", null, encodedMessage);
         }
 
+        protected override Task<string> SignMessageAsyncCore(byte[] rawMessage)
+        {
+            var encodedMessage = rawMessage.ToHex(true);
+            return Web3.Client.SendRequestAsync<string>("personal_sign", null, encodedMessage);
+        }
+
 
         // -- Verify Message -------------------------------------------
 

diff --git a/src/Reown.AppKit.Unity/Runtime/Evm/WagmiEvmService.cs b/src/Reown.AppKit.Unity/Runtime/Evm/WagmiEvmService.cs
@@ -25,6 +25,11 @@ protected override Task<string> SignMessageAsyncCore(string message)
             return WagmiInterop.SignMessageAsync(message);
         }
 
+        protected override Task<string> SignMessageAsyncCore(byte[] rawMessage)
+        {
+            return WagmiInterop.SignMessageAsync(rawMessage);
+        }
+
         protected override Task<bool> VerifyMessageSignatureAsyncCore(string address, string message, string signature)
         {
             return WagmiInterop.VerifyMessageAsync(address, message, signature);

diff --git a/src/Reown.AppKit.Unity/Runtime/WebGL/Wagmi/WagmiInterop.cs b/src/Reown.AppKit.Unity/Runtime/WebGL/Wagmi/WagmiInterop.cs
@@ -106,6 +106,19 @@ public static Task<string> SignMessageAsync(string message)
             return SignMessageAsync(parameter);
         }
 
+        public static Task<string> SignMessageAsync(byte[] rawMessage)
+        {
+            var parameter = new SignRawMessageParameter
+            {
+                message = new
+                {
+                    raw = rawMessage
+                }
+            };
+
+            return InteropCallAsync<SignRawMessageParameter, string>(WagmiMethods.SignMessage, parameter);
+        }
+
         public static Task<string> SignMessageAsync(SignMessageParameter parameter)
         {
             return InteropCallAsync<SignMessageParameter, string>(WagmiMethods.SignMessage, parameter);

diff --git a/src/Reown.AppKit.Unity/Runtime/WebGL/Wagmi/WagmiModel.cs b/src/Reown.AppKit.Unity/Runtime/WebGL/Wagmi/WagmiModel.cs
@@ -21,6 +21,12 @@ public class SignMessageParameter
         public string message;
     }
 
+    [Serializable]
+    public class SignRawMessageParameter
+    {
+        public object message;
+    }
+
     [Serializable]
     public class VerifyMessageParameters
     {

diff --git a/src/Reown.Sign.Nethereum/Runtime/Extensions.cs b/src/Reown.Sign.Nethereum/Runtime/Extensions.cs
@@ -2,6 +2,7 @@
 using System.Linq;
 using System.Threading.Tasks;
 using Newtonsoft.Json;
+using Reown.Core.Common.Logging;
 using Reown.Core.Common.Model.Errors;
 using Reown.Sign.Interfaces;
 using Reown.Sign.Nethereum.Model;
@@ -38,6 +39,8 @@ public static async Task SwitchEthereumChainAsync(this ISignClient signClient, E
                         var metaMaskError = JsonConvert.DeserializeObject<MetaMaskError>(e.Message);
                         if (metaMaskError is { Code: 4001 }) // If user rejected
                             throw;
+
+                        ReownLogger.LogError($"[MetaMask Error] {metaMaskError.Message}");
                     }
                     catch (Exception)
                     {