fix: social login popup blocked by safari #3878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 79596e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Skipped Deployments
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
enesozturk
reviewed
Feb 19, 2025
Comment on lines
37
to
39
| vi.spyOn(AccountController, 'setSocialProvider') | ||
| vi.spyOn(EventsController, 'sendEvent') | ||
| vi.spyOn(RouterController, 'push') |
There was a problem hiding this comment.
Do we need to spyOn these if we don't check them if they are called or not?
enesozturk
approved these changes
Feb 19, 2025
tomiir
reviewed
Feb 19, 2025
Comment on lines
240
to
251
| this.popupWindow = CoreHelperUtil.returnOpenHref( | ||
| '', | ||
| 'popupWindow', | ||
| 'width=600,height=800,scrollbars=yes' | ||
| ) | ||
|
|
||
| if (this.popupWindow) { | ||
| AccountController.setSocialWindow(this.popupWindow, ChainController.state.activeChain) | ||
| } else { | ||
| throw new Error('Something went wrong') | ||
| } | ||
|
|
There was a problem hiding this comment.
does this impact TG integration @ganchoradkov ?
There was a problem hiding this comment.
most likely yes, this.popupWindow is undefined in telegram context so the logic will not continue with this throw
svenvoskamp
reviewed
Feb 19, 2025
| @@ -237,34 +237,38 @@ export class W3mSocialLoginWidget extends LitElement { | |||
|
|
|||
| try { | |||
| if (authConnector && socialProvider) { | |||
| this.popupWindow = CoreHelperUtil.returnOpenHref( | |||
There was a problem hiding this comment.
We open new window here and also opening new window in (CoreHelperUtil.isTelegram()) {...}. Not sure if this breaks stuff in telegram
svenvoskamp
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have an asynchronous function which takes time to load up the popup window which then causes browsers like safari to block our popup window.
Type of change
Associated Issues
For Linear issues: Closes APKT-2306
Checklist