Conversation
lukasbischof
force-pushed
the
feature/pg-command
branch
from
507ef6b to
770623b
Compare
| kind = data["kind"] || "" | ||
|
|
||
| unless kind == "Postgres" || @nctl.dry_run | ||
| Output.error("Backups can only be downloaded for PostgreSQL databases. (shared dbs are not supported)") |
There was a problem hiding this comment.
Not supported yet afaik
coorasse
left a comment
coorasse
left a comment
There was a problem hiding this comment.
Amazing! One of the most useful features!!!
In all the other commands we use --app to define the app, shouldn't we follow the same pattern here? Otherwise it might be confusing.
deploio pg backups download --app APP_NAME.
this would download the backup of the DATABASE_URL of the app by default, otherise we could specify the --db?
I want to hear your opinion
| def get_all_pg_databases | ||
| output_dedicated_dbs = capture("get", "postgres", "-A", "-o", "json") | ||
| output_shared_dbs = capture("get", "postgresdatabase", "-A", "-o", "json") | ||
| if (output_dedicated_dbs.nil? || output_dedicated_dbs.empty?) && |
There was a problem hiding this comment.
| if (output_dedicated_dbs.nil? || output_dedicated_dbs.empty?) && | |
| if output_dedicated_dbs.empty? && |
if it's nil, .empty? returns true already, no?
|
Thanks for the inputs @coorasse. I like the idea that you don't have to specify the database but rather an app. Coming to |
# Conflicts: # lib/deploio/nctl_client.rb
^ Conflicts: ^ lib/deploio/completion_generator.rb ^ lib/deploio/templates/completion.zsh.erb
coorasse
force-pushed
the
feature/pg-command
branch
from
770623b to
f332c35
Compare
|
This command is too useful. |
2 participants
I wanted to have a unified CLI that manages dedicated and shared databases and provides an interface to get backups so I can use them locally
Screenshot.on.2026-02-04.at.17.11.mp4
I followed the same scheme of having -. Sadly, this leads to some weird names when we had the project name repeated in the database name