-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gemstash compatibility added #7111
Conversation
|
Try running But also, doesn't this solution try/fail for every dependency? i.e. if you need to look up 20 dependencies, it will result in 20 * 404 errors in addition to the 200 * 200 OK? |
Indeed. But a Gemfile can contain gems from multiple sources. We canno't know in advance if the gem can be fetched from I will do more tests locally as the unit tests broke. |
I'd wondered if we could detect when a particular registryUrl does not support the traditional endpoint and then "remember" that for subsequent requests |
Maybe via a |
I think it's ok to try/fail but I prefer we only do it once per run instead of once per dependency. |
This PR adds a check to use the
api/v1/dependencies.json
endpoint ifapi/v1/versions
does not exist.It is currently the case for the Gemstash repository.
Closes #6787