Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): Add axum monorepo #33362

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Jan 1, 2025

Changes

This PR adds a new monorepo group: axum (-> https://github.com/tokio-rs/axum/)

Context

This should group rust-lang/crates.io#10302 and rust-lang/crates.io#10303 into a single pull request. axum is one of the most popular web frameworks for the Rust language.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Turbo87 Turbo87 changed the title Add axum monorepo group feat: Add axum monorepo group Jan 1, 2025
@viceice viceice changed the title feat: Add axum monorepo group feat(presets): Add axum monorepo Jan 1, 2025
viceice
viceice previously approved these changes Jan 1, 2025
@viceice viceice dismissed their stale review January 1, 2025 18:19

need more discussions

@viceice
Copy link
Member

viceice commented Jan 1, 2025

we should only group as monorepo when they share same version otherwise we'll get unwanted immortal PRs

@Turbo87
Copy link
Contributor Author

Turbo87 commented Jan 1, 2025

hmm, I'm pretty sure I've seen plenty of other groupings with diverging versions already 🤔

how else could this issue be solved then?

@rarkins rarkins added this pull request to the merge queue Jan 2, 2025
Merged via the queue into renovatebot:main with commit 5390390 Jan 2, 2025
39 checks passed
@Turbo87 Turbo87 deleted the axum-group branch January 2, 2025 08:12
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.88.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants