Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasource): add eks addon datasource #33272

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Dec 24, 2024

credits to #29613

What is in this PR

  • sync @aws-sdk/client-* dependencies
  • added extra tests
  • supported case when cluster version is not specified
  • added aws-eks-addon versioning. This will not require "ignoreUnstable": false
  • added defaultConfig as default prTitle not able safely parse packageName object
    Screenshot 2024-12-26 at 16 37 51

Branch name is dodgy as well, no fix in this pull request, but can tweak it, just feels like missing something like {{ toString packageName }}

Screenshot 2024-12-26 at 15 54 41

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

Signed-off-by: ivan katliarchuk <[email protected]>
* main:
  fix(deps): update ghcr.io/renovatebot/base-image docker tag to v9.27.4 (renovatebot#33271)
@ivankatliarchuk ivankatliarchuk marked this pull request as draft December 24, 2024 17:50
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
@viceice viceice changed the title feat(23410): eks addon refresh feat(datasource): add eks addon datasource Dec 24, 2024
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
* main:
  chore(deps): update python:3.13 docker digest to 08371fa (renovatebot#33282)
  build(deps): update dependency @opentelemetry/instrumentation-bunyan to v0.45.0 (renovatebot#33281)
  build(deps): update opentelemetry-js monorepo (renovatebot#33279)
  fix(deps): update ghcr.io/renovatebot/base-image docker tag to v9.27.5 (renovatebot#33278)
  chore(deps): update python:3.13 docker digest to c286f03 (renovatebot#33277)
  chore(deps): update containerbase/internal-tools action to v3.5.15 (renovatebot#33273)
@ivankatliarchuk ivankatliarchuk force-pushed the feat-23410 branch 2 times, most recently from e4a2bbf to 6663a43 Compare December 26, 2024 16:48
* main:
  feat(preset): Add oracle database jdbc and nls monorepo groups (renovatebot#33287)
  chore(deps): update python:3.13 docker digest to cea505b (renovatebot#33285)
  chore(deps): update python:3.13 docker digest to a76a2a0 (renovatebot#33284)
  chore(deps): update python:3.13 docker digest to 52d1bb8 (renovatebot#33283)
@ivankatliarchuk ivankatliarchuk marked this pull request as ready for review December 26, 2024 16:48
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
* main:
  chore(deps): update ghcr.io/containerbase/devcontainer docker tag to v13.5.3 (renovatebot#33291)
  fix(deps): update ghcr.io/containerbase/sidecar docker tag to v13.5.3 (renovatebot#33292)
@ivankatliarchuk
Copy link
Contributor Author

Hi, @viceice. Is there any chance you have a look?

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please split PR. move versioning to be merged first

@ivankatliarchuk
Copy link
Contributor Author

Added Versioning #33301

@ivankatliarchuk
Copy link
Contributor Author

ivankatliarchuk commented Dec 27, 2024

Shell I w8 for versioning to be merged and then rebase this pull request or?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

customDatasources: allow to run external binaries to generate result
2 participants