Lean: Supporting enums with number conversions #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasgrosser
approved these changes
Jan 30, 2025
javra
reviewed
Jan 30, 2025
| @@ -160,6 +160,7 @@ let rec doc_typ ctx (Typ_aux (t, _) as typ) = | |||
| if provably_nneg ctx low then string "Nat" else string "Int" | |||
| | Typ_var kid -> doc_kid ctx kid | |||
| | Typ_app (id, _) -> doc_id_ctor id | |||
| | Typ_exist (_, _, typ) -> doc_typ ctx typ | |||
There was a problem hiding this comment.
What are the first two components?
There was a problem hiding this comment.
the first one is k_ids, and the second is n_constraints on these k_ids
It's quantifiers on the output values
There was a problem hiding this comment.
Then I think it's safe to ignore the constraints and leave the k_ids implicit for now
javra
approved these changes
Jan 30, 2025
|
@javra I forgot that this commit was also needed to replace |
lfrenot
force-pushed
the
lean/id-exists
branch
from
e8f29e9 to
53c1a35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.