Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lean: Fixing Lean style and wrong definition in Sail.lean #891

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

lfrenot
Copy link
Collaborator

@lfrenot lfrenot commented Jan 16, 2025

This fixes the style in Sail.lean (spaces before colons and camelCase function names) and fixes the definition of truncateLsb to actually extract the most significant bits.

@lfrenot lfrenot requested review from ineol and javra January 16, 2025 11:00
@lfrenot
Copy link
Collaborator Author

lfrenot commented Jan 16, 2025

See the discussion in #817

Copy link

github-actions bot commented Jan 16, 2025

Test Results

   12 files  ±0     24 suites  ±0   0s ⏱️ ±0s
  747 tests ±0    747 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 490 runs  ±0  2 490 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2110c8a. ± Comparison against base commit d02e965.

♻️ This comment has been updated with latest results.

@javra
Copy link
Collaborator

javra commented Jan 16, 2025

LGTM then!

@bacam bacam merged commit bf921f9 into rems-project:sail2 Jan 16, 2025
3 checks passed
@lfrenot lfrenot deleted the lean-style-fix branch January 17, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants