CN: Tidy IT, Id, LC modules #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These getters conflicted with the normal names for variables of that type, which leads to annoying and confusing error messages when the module is (frequently) opened, and leads to extra ' on the variable names to compensate.
With the previous commit, some shorter renames are now possible, such as basetype => get_bt, and loc' => loc.
This makes the new location in making identifiers explicit.
dc-mak
force-pushed
the
cn-tidy-it-id-lc
branch
2 times, most recently
from
81dfa30 to
18c8a56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.