Skip to content

Conversation

@JonnyBurger
Copy link
Member

No description provided.

@vercel
Copy link
Contributor

vercel bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
bugs Ready Ready Preview Comment Oct 21, 2025 9:08am
remotion Ready Ready Preview Comment Oct 21, 2025 9:08am

Copy link
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments:

packages/it-tests/pure.js (line 347):
The test fixture file packages/it-tests/pure.js contains outdated audio codec configuration that doesn't match the source code changes. This compiled/bundled file needs to be regenerated to reflect the removal of pcm-16 support from the aac codec.

View Details
📝 Patch Details
diff --git a/packages/it-tests/pure.js b/packages/it-tests/pure.js
index c32df4d746..c466c937b0 100644
--- a/packages/it-tests/pure.js
+++ b/packages/it-tests/pure.js
@@ -335,24 +335,24 @@ var require_audio_codec = __commonJS((exports) => {
   Object.defineProperty(exports, "__esModule", { value: true });
   exports.audioCodecOption = exports.getDefaultAudioCodec = exports.resolveAudioCodec = exports.getExtensionFromAudioCodec = exports.defaultAudioCodecs = exports.mapAudioCodecToFfmpegAudioCodecName = exports.supportedAudioCodecs = exports.isAudioCodec = exports.validAudioCodecs = undefined;
   var separate_audio_1 = require_separate_audio();
-  exports.validAudioCodecs = ["pcm-16", "aac", "mp3", "opus"];
+  exports.validAudioCodecs = ["pcm-16", "aac", "mp3", "opus", "pcm-24"];
   var isAudioCodec = (codec) => {
     return codec === "mp3" || codec === "aac" || codec === "wav";
   };
   exports.isAudioCodec = isAudioCodec;
   exports.supportedAudioCodecs = {
-    h264: ["aac", "pcm-16", "mp3"],
-    "h264-mkv": ["pcm-16", "mp3"],
-    "h264-ts": ["pcm-16", "aac"],
-    aac: ["aac", "pcm-16"],
+    h264: ["aac", "pcm-16", "pcm-24", "mp3"],
+    "h264-mkv": ["pcm-16", "pcm-24", "mp3"],
+    "h264-ts": ["pcm-16", "pcm-24", "aac"],
+    aac: ["aac"],
     avi: [],
     gif: [],
-    h265: ["aac", "pcm-16"],
+    h265: ["aac", "pcm-16", "pcm-24"],
     mp3: ["mp3", "pcm-16"],
     prores: ["aac", "pcm-16"],
     vp8: ["opus", "pcm-16"],
     vp9: ["opus", "pcm-16"],
-    wav: ["pcm-16"]
+    wav: ["pcm-16", "pcm-24"]
   };
   var _satisfies = exports.supportedAudioCodecs;
   if (_satisfies) {

Analysis

Bundled test fixture contains outdated audio codec configuration

What fails: The bundled test file packages/it-tests/pure.js contains outdated validAudioCodecs and supportedAudioCodecs definitions that don't match the current source code in packages/renderer/src/options/audio-codec.tsx

How to reproduce:

cd packages/it-tests
node -e "const fs = require('fs'); const content = fs.readFileSync('pure.js', 'utf8'); console.log('Missing pcm-24:', !content.includes('pcm-24')); console.log('AAC still includes pcm-16:', content.match(/aac: \[(.*?)\]/)[1].includes('pcm-16'));"

Result: Shows Missing pcm-24: true and AAC still includes pcm-16: true

Expected: The bundled file should match the source code where validAudioCodecs includes 'pcm-24' and supportedAudioCodecs.aac is ['aac'] only per renderer source code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants