fix(termination): parse minDate as ISO string to ensure correct date handling #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for remote-flows ready! ✅ Preview Built with commit 90eb334. |
|
Deploy preview for remote-flows-example-app ready! ✅ Preview Built with commit 90eb334. |
cammellos
approved these changes
Nov 4, 2025
gabrielseco
deleted the
pbyr-3139-limit-provisional-start-date-to-make-the-mindate-today
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes date parsing in the DatePickerField component to correctly handle minDate values passed as ISO date strings.
Technical Details
The previous implementation using
new Date(minDate)could lead to incorrect date interpretation due to timezone handling. Usingdate-fns'sparsefunction with explicit format string ('yyyy-MM-dd') ensures consistent and reliable date parsing across different environments.