Add homepage confetti effect for 50th Remote Hack celebration #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfoxall
commented
Jun 23, 2024
Comment on lines
+53
to
+57
| setInterval(createConfetti, 100); | ||
|
|
||
| // Stop creating confettis after 5 seconds | ||
| setTimeout(() => { | ||
| clearInterval(createConfetti); |
There was a problem hiding this comment.
There's no interval id being stored, so it'll never stop 🤔
There was a problem hiding this comment.
If you can limit it easily to just the homepage then I think this is fine
There was a problem hiding this comment.
Yep I guess it is fine! I thought it was worth noting that the code from Copilot Workspace Preview has syntax issues 😓
lpmi-13
reviewed
Jun 23, 2024
| confetti.y += confetti.speed; | ||
| confetti.x += Math.cos(confetti.angle) * confetti.speed; | ||
|
|
||
| // Remove confetti that are out of the screen |
There was a problem hiding this comment.
If we don't do this, it is basically just a memory leak?
lpmi-13
approved these changes
Jun 23, 2024
|
@lpmi-13 I generated this PR using the Copilot Workspace Preview 😎 . It took me a few attempts to get this PR, and I think there's still some issues with it! Will try and fix it up and merge if I get a chance. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a celebratory confetti effect to the homepage for the 50th Remote Hack event, respecting user preferences for reduced motion and only triggering under specific conditions.
assets/confetti.jsthat creates a falling confetti effect using plain JavaScript. This effect respects the "prefers-reduced-motion" media query and automatically stops generating new confetti after 5 seconds._hacks/50.mdto includecelebrate: truein the front matter, which is used to conditionally trigger the confetti effect._layouts/default.htmlto conditionally include theconfetti.jsscript based on thecelebrate: truecondition in the front matter of the event page.For more details, open the Copilot Workspace session.