feat: use ?inline
to load critical styles
#10254
Open
+18
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default export of css files was removed in Vite v5, but it was accidently left for SSR. Vite v6 removes that (vitejs/vite#17922). This PR changes the critical style loader to use
?inline
imports to make remix compatible with Vite v6.Testing Strategy: I ran
pnpm i && pnpm vite-ecosystem-ci:build && pnpm vite-ecosystem-ci:test
with both Vite 5.x and 6.x.