fix: Forward Deno ServeHandlerInfo to getLoadContext #10042
Conversation
🦋 Changeset detectedLatest commit: bdfcd49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
This adds a Remix adapter. We provide a special `getLoadContext` export which is demonstrated in the example application. It currently looks up the IP from an Express or Deno server, but we're waiting on remix-run/remix#10042 before their Deno plugin will provide the argument we need. Closes #1313
|
We've released Remix support in Arcjet, but without these changes, it won't work on the Deno runtime 😢 |
|
Thank you for opening this pull request, and our apologies we haven't gotten around to it yet! With the release of React Router v7 we are sun-setting continued development/maintenance on Remix v2. If you have not already upgraded to React Router v7, we recommend you do so. We've tried to make the upgrade process as smooth as possible with our Future Flags. We are now in the process of cleaning up outdated issues and pull requests to improve the overall hygiene of our repositories. We plan to continue to address 2 types of issues in Remix v2:
If you believe this pull request meets one of those criteria, please respond or create a new pull request so it pops up on our radar (since github notifications may get lost in the noise 😕). For all other issues/changes, ongoing maintenance will be happening in React Router v7, so:
If you have any questions you can always reach out on Discord. Thanks again for providing feedback and helping us make our framework even better! |
This forwards the 2nd argument from the
Deno.serveAPI togetLoadContext. This is the only way to access the IP of a request so it needs to be available if you want to make the IP available in the Context.Testing Strategy:
Setup a Deno example and inspect the info via the
getLoadContexthandler. I didn't see any Deno tests in a quick search, but let me know if I missed them.