fix(showcase): update wrong url #303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure about this change : The repo links to the website, but the website doesn't seem to link back to the repo. |
|
Thanks. Is this an intentional link to a Github repository? If so, I will close this PR. |
|
@jsparkdev Adding this entry was suggested here: remix-run/remix#7503 (comment) At the time, we did distinguish between website & repo, but I guess we got rid of repo since a lot of sites have closed sources and it was empty most of the time. let's defer to @brookslybrand for the final call 🙌🏼 |
|
@machour I didn't realize this had been discussed so much before, thanks for the info! I will keep this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Github repository url with website url.