chore(react-router): cleanup test setup#13724
Conversation
|
a26cc05 to
aba1e84
Compare
|
Just bear in mind that jest-fixed-jsdom is largely a hack and shouldn't be used as a long-lasting solution. If you can, please explore migrating your tests to run in the browser (Browser Mode in Vitest, Component testing in Playwright and Cypress). Much simpler setup, much better tests, but you need to pay some attention migrating. |
aba1e84 to
5c18446
Compare
|
lets stick with |
|
I pulled back in our global |
* chore(react-router): cleanup test setup * Reset back to manual node global patching --------- Co-authored-by: Matt Brophy <matt@brophy.org>
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
These are all available in Node 20 (which is the minimum we use)Since we're still using
jestandjest-environment-jsdomwe unfortunatelly can't fully remove these 😢Decided to go with @kettanaito / @mswjs'
jest-fixed-jsdomthough as it's handling more cases than we currently do and it's one less thing we need to worry about ourselves