Escape paths passed to optimizeDeps.entries
#13570
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d050831 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This PR was opened to address an issue raised in Discord, but it looks like it might be an underlying Vite issue. I'm marking this as draft for now until we track down what the issue is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values passed to
optimizeDeps.entriesare expected to be tinyglobby patterns, not file paths. We're currently passing file paths which means that any special matching characters in file names will accidentally trigger pattern matching.To fix this, we now pass all paths through escapePath.
In terms of versioning, I've ensured we depend on the same tinyglobby version range as Vite: https://github.com/vitejs/vite/blob/main/packages/vite/package.json#L93
Note that in Vite v5, the globs are passed to fast-glob instead of tinyglobby, but since tinyglobby is a drop-in replacement, we don't need to do any version detection.