fix(react-router/router): properly escape :param values in generatePath()#13530
Merged
brophdawg11 merged 3 commits intodevfrom Aug 19, 2025
Merged
fix(react-router/router): properly escape :param values in generatePath()#13530brophdawg11 merged 3 commits intodevfrom
:param values in generatePath()#13530brophdawg11 merged 3 commits intodevfrom
Conversation
🦋 Changeset detectedLatest commit: 50aedcc The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
reviewed
Aug 19, 2025
Contributor
|
🤖 Hello there, We just published version Thanks! |
MichaelDeBoey
changed the title
:param values in generatePath()
Contributor
|
🤖 Hello there, We just published version Thanks! |
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Nov 10, 2025
It was introduced to work around React Router v6's issue of not encoding parameters in the generatePath function. However, after migrating to v7, tests began failing due to double encoding. This revealed that React Router v7 already handles encoding parameters in generatePath. See remix-run/react-router#13530 Thus, this commit reverts the changes made in #2576
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Nov 10, 2025
## Problem React Router v7 was released almost a year now (see https://reactrouter.com/changelog#v700), but it has not been updated in Agama yet. In addition to the obvious benefit of keeping dependencies up-to-date, updating it might help to address some limitations we have found with the v6 version, like 06d858c ## Solution Migrate React Router dependency to its latest version. ## Testing - Adapted existing tests. ## Notes This migration has been straightforward, and as of now, Agama is using Data Mode (see https://reactrouter.com/start/modes). However, this could change in the future if we find advantages in switching to Declarative or Framework Mode. Before making any decisions, we’ll need to work on `src/App.tsx` along with the changes planned for the api-v2 branch that this PR is based on. ## Documentation * https://reactrouter.com/upgrading/v6 * remix-run/react-router#12363 (comment) * remix-run/react-router#13530 (`generatePath` now encodes URL params by default, related to #2576) * https://www.typescriptlang.org/tsconfig/#moduleResolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11940