Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-react-router): add Deno support #12327

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

redabacha
Copy link

taken from remix-run/remix#9932. it's possible to detect older deno versions with process.versions.deno but i don't think it's worth doing.

Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: 9211515

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-react-router Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 20, 2024

Hi @redabacha,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@@ -512,19 +512,11 @@ async function doneStep(ctx: Context) {
await sleep(200);
}

type PackageManager = "npm" | "yarn" | "pnpm" | "bun";

const packageManagerExecScript: Record<PackageManager, string> = {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the create-react-router project doesn't seem to have init script support that remix did so i've refactored this a little to simplify.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 20, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title Add Deno as a supported package manager in create-react-router feat(create-react-router): add Deno support Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant