Improve config change handling #12319
Open
+205
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8842539 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pcattori
reviewed
Nov 21, 2024
markdalgleish
commented
Nov 21, 2024
| } | ||
| let configCodeChanged = | ||
| configFileAddedOrRemoved || | ||
| (typeof reactRouterConfigFile === "string" && |
There was a problem hiding this comment.
Use Boolean or !== undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this is some minor polish that can go out after the initial v7.0.0 release.
This makes the following improvements to
react-router.config.tschange handling while the dev server / typegen watch is running:react-router.config.tsis created or deleted.appDirectoryand updates the file watcher, unwatching the old directory and watching the new one.