allow undefined in setSearchParams

[mschiltknecht]

Currently, when one uses

const [searchParams, setSearchParams] = useSearchParams(),

then setSearchParams has to be used like this:

const filterA: string | undefined = getFilter('A');
const filterB: string | undefined = getFilter('B');
const filterC: string | undefined = getFilter('C');

const params: Record<string, string> = {
  ...(filterA && { filterA }),
  ...(filterB && { filterB }),
  ...(filterC && { filterC }),
};

setSearchParams(params);

Note that setting the properties of the params object to empty strings has a different behavior:

const params: Record<string, string> = {
  filterA: filterA ?? '',
  filterB: filterB ?? '',
  filterC: filterC ?? ''
};

setSearchParams(params);

In this case (with empty strings) the url will look like this: "localhost:1234/?filterA=&filterB=&filterC=", which is not expected, I suppose it should just be "localhost:1234" instead.

Hence the proposed changes.

[remix-cla-bot]

Hi @mschiltknecht,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[changeset-bot]

⚠️ No Changeset found

Latest commit: f1e2e33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR