Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: request.signal.aborted older browsers compatibility #12106

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

BrianWoolfolk
Copy link

Closes #11907

Added optional chaining operator (?.) when checking for signal.aborted because it throws an error in older browsers.

Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: 2fa5742

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@felipeloge
Copy link

Any chance of merging this as soon as possible? This issue is directly affecting a cordova app I have.
Just to give more context, the cordova app loads a micro frontend application that has your own router. In this case, it's using the react router (latest version). However testing in iOS it's occurring this issue and the changes applied by this PR solve the issue.

Thanks in advance.

@timdorr
Copy link
Member

timdorr commented Oct 10, 2024

@felipeloge An easy workaround is to add Request.prototype.signal = {} somewhere globally in your app as a "polyfill" of sorts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants