Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Route chunks #11871

Draft
wants to merge 38 commits into
base: dev
Choose a base branch
from
Draft

WIP: Route chunks #11871

wants to merge 38 commits into from

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Aug 5, 2024

#11571

TODO:

  • Wire up to Vite plugin.
  • Handle TSX.
  • Ignore types in dependency analysis.
  • HMR
  • Caching
  • Refactor getRouteChunks into singular getRouteChunk to improve performance/caching
  • Ensure all route chunks are preloaded
  • Split shared import statements
  • Handle import side effects
  • Handle export { foo, bar }
  • Handle export { foo, bar as baz } from "./module"
  • Handle export * from "./module"
  • Handle export {}
  • Handle export const foo = ..., bar = ...;
  • Handle export const { foo } = ...; etc.
  • Harden export dependency analysis
  • Ensure consumers importing a route module doesn't result in duplicate code
  • Allow shared imports across chunks
  • Integration tests
  • Ensure HMR can handle addition of main chunk
  • Fix unused import removal in omitChunkedExports now that shared imports don't de-opt
  • Ensure chunked exports download first
  • Strict mode (build breaks on de-opt)
  • Changeset
  • Docs
  • Tidy HMR snippets when route chunks disabled?
  • Skip route chunk build entries when future flag disabled?
  • Clean empty route chunks from build output?

Copy link

changeset-bot bot commented Aug 5, 2024

⚠️ No Changeset found

Latest commit: e0fb3b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant