Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dirty hack #99

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

eclipse95
Copy link

Hi,
I see that there is a "dirty hack" in the Dockerfile.
I see that your module uses C++17 and OTB doesn't fully support it.
This PR set C++ 17 only for your module in CMakefile. So, it removed the dirty hack in the Dockerfile.

I have also added Python dependencies in the setup.py.
I have split the PR in 3 distinct commits if you prefer cherry-pick it.

@remicres
Copy link
Owner

Thanks a lot @eclipse95 !
I'll check how the CI behaves with the proposed changes this week

@remicres
Copy link
Owner

Unfortunately the CI does not pass at the docker build stage.

Did you succeed to build the docker image with the proposed changes? If yes, could you provide the ARGs used? (OTB version, etc)

Thanks

@eclipse95
Copy link
Author

eclipse95 commented May 30, 2024

Hi,
OK, I didn't check in the same context. I built Debian packages OTB+OTBTF (to use it on Colab). I take OTB from Debian upstream repository (OTB version 8.1.2). I didn't use "super build", but the default used by Debian with some tweaks, so some features (such as OTB_USE_6S) are not built.

I will check with the Dockerfile provided in the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants