Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I see that there is a "dirty hack" in the Dockerfile.
I see that your module uses C++17 and OTB doesn't fully support it.
This PR set C++ 17 only for your module in CMakefile. So, it removed the dirty hack in the Dockerfile.
I have also added Python dependencies in the setup.py.
I have split the PR in 3 distinct commits if you prefer cherry-pick it.