Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick lint from downstream_issue.py #262

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

webbnh
Copy link
Collaborator

@webbnh webbnh commented Dec 9, 2024

This PR is the last in the series of revisions originally set out in #207 which endeavors to improve code quality in Sync2Jira; this is the follow-on to #261.

This change picks lint from the downstream-issues module:

  • adds some type hints to resolve incorrect type inference in the IDE
  • makes editorial corrections in code comments
  • removes unneeded escape characters from a character-set in a regular expression
  • replaces camelCase with snake_case
  • renames identifiers whose declarations shadow identifiers from outer scopes
  • adds a missing function parameter description
  • removes an unused function parameter

Also this PR contains two changes for the _close_as_duplicate() function:

  • adds text to duplicated log messages to disambiguate them
  • adds a guard to a condition exception handler to avoid accesses to nonexistent attributes

@ralphbean ralphbean merged commit 0b2592c into main Dec 9, 2024
6 checks passed
@ralphbean ralphbean deleted the pick-lint-from-downstream_issue branch December 9, 2024 19:52
@ralphbean ralphbean restored the pick-lint-from-downstream_issue branch December 9, 2024 19:52
@ralphbean ralphbean deleted the pick-lint-from-downstream_issue branch December 9, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants