Skip to content
This repository was archived by the owner on Mar 5, 2020. It is now read-only.

Conversation

@cxj
Copy link
Contributor

@cxj cxj commented Jun 8, 2017

No description provided.

@pmjones
Copy link
Contributor

pmjones commented Jun 9, 2017

@cxj Given your followup comment in #24 do you still consider this a good fix?

@cxj
Copy link
Contributor Author

cxj commented Jun 9, 2017

I suspect this fix is inadequate. What's needed is for the calling code to be notified in some way of the error, so that it can log or otherwise handle it in an appropriate way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants