-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support relay v16 + refactor useForceUpdate + react v18 strict #268
Conversation
Hi @gkaindl, @eMerzh, @Lalitha-Iyer, I also updated the example project https://github.com/relay-tools/relay-hooks/tree/master/examples/relay-hook-example/pagination-nextjs-ssr to the latest releases of nextjs, relay and react in strict mode. |
@eMerzh very curious, I integrated into this PR the other one where you didn't have the problem did you run relay-compiler again? |
i'm really really sorry, yeah it seems i didn't test properly or soemthing change? anyways, i tried to dig it ... with a fragment beeing @refetchable on a Node ... make it break.. https://github.com/relay-tools/relay-hooks/pull/268/files#diff-3478363f24e7381f9b3f144c18b1c2f8f5f1dc73c968d65c4ef9da948b6d6f2aR574 |
It seems like a problem with the files generated by the compiler or different versions of relay-runtime. Do you check in the generated file if you have this?
|
omg 😮💨 🤦 ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do it! Thank you!
Verified [email protected] with [email protected] and relay-compiler@^16.0.0 on our code base. Don't see any functional or performance issues. Thanks for tagging me ! |
Perfect, as soon as I can I'll merge and release version 9.0.0 :) Thanks you all |
Include: