Skip to content

Conversation

@vio
Copy link
Member

@vio vio commented Nov 9, 2025

Summary by CodeRabbit

  • New Features

    • Broadened plugin compatibility to support both Rollup and Vite plugin types.
    • Introduced typed output options to improve build integrations.
  • Chores

    • Bumped package to 2.1.8-beta.2.
    • Updated development tooling (Vite 7.2.2) and adjusted peer dependency ordering.

@coderabbitai
Copy link

coderabbitai bot commented Nov 9, 2025

Walkthrough

Bumps package version to 2.1.8-beta.2, adds devDependency "vite": "7.2.2", and swaps the order of the "rolldown" and "vite" entries in peerDependencies. Adds src/types.ts exporting Plugin as VitePlugin and OutputOptions as RollupOutputOptions. Updates src/plugin.ts to import type definitions from ./types (type-only import) instead of rollup. No runtime logic or exported API signatures were changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Confirm src/types.ts exports Plugin = VitePlugin and OutputOptions = RollupOutputOptions as stated.
  • Verify src/plugin.ts now imports types from ./types with type-only imports and that no runtime imports were introduced.
  • Check package.json: version changed to 2.1.8-beta.2, devDependency vite added, and peerDependencies entries reordered.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: Add explicit plugin types' directly describes the main change: introducing explicit type aliases (Plugin and OutputOptions) in a new types module.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-plugin-types

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link

socket-security bot commented Nov 9, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedvite@​7.1.11 ⏵ 7.2.298 +11008299 +1100

View full report

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
package.json (1)

89-91: Clarify intent behind peerDependencies reordering.

The peerDependencies were reordered from [vite, rollup, rolldown] to [rolldown, rollup, vite], but version constraints remain unchanged. If this reordering follows a specific convention (alphabetical or priority-based), please confirm. If it's incidental cleanup, consider reverting to maintain consistency with common practices (e.g., peerDependencies ordered by relevance to the primary use case—Vite first for a Vite plugin).

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b3e7ab and 20d7ab2.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json (2 hunks)
  • src/types.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/types.ts
🔇 Additional comments (2)
package.json (2)

3-3: Version bump to 2.1.8-beta.2 is appropriate.

The beta pre-release version aligns with the type system improvements introduced in this PR.


82-82: Vite 7.2.2 addition is well-motivated.

Adding vite as a devDependency ensures the development environment has explicit support for Vite 7.x testing and aligns with the peerDependency constraint (^7.0.0). This supports the PR objective of adding explicit plugin types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants