-
Notifications
You must be signed in to change notification settings - Fork 3
fix: Add explicit plugin types #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughBumps package version to 2.1.8-beta.2, adds devDependency "vite": "7.2.2", and swaps the order of the "rolldown" and "vite" entries in peerDependencies. Adds src/types.ts exporting Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
89-91: Clarify intent behind peerDependencies reordering.The peerDependencies were reordered from
[vite, rollup, rolldown]to[rolldown, rollup, vite], but version constraints remain unchanged. If this reordering follows a specific convention (alphabetical or priority-based), please confirm. If it's incidental cleanup, consider reverting to maintain consistency with common practices (e.g., peerDependencies ordered by relevance to the primary use case—Vite first for a Vite plugin).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
package.json(2 hunks)src/types.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/types.ts
🔇 Additional comments (2)
package.json (2)
3-3: Version bump to 2.1.8-beta.2 is appropriate.The beta pre-release version aligns with the type system improvements introduced in this PR.
82-82: Vite 7.2.2 addition is well-motivated.Adding vite as a devDependency ensures the development environment has explicit support for Vite 7.x testing and aligns with the peerDependency constraint (
^7.0.0). This supports the PR objective of adding explicit plugin types.
Summary by CodeRabbit
New Features
Chores