refactor(consensus): split onPropose #182
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added check and createVote functions which do not have sideeffects and should be easier to test.
leandernikolaus
commented
Jan 28, 2025
| if qcBlock, ok := cs.blockChain.Get(block.QuorumCert().BlockHash()); ok { | ||
| cs.acceptor.Proposed(qcBlock.Command()) | ||
| } else { | ||
| cs.logger.Info("OnPropose: Failed to fetch qcBlock") |
There was a problem hiding this comment.
I believe this case can never happen since the existence of the qcBlock was already checked when verifying the QC.
Should we remove the whole if?
I keep getting weird behavior from git when switching between branches, resulting in seeming conflicts when there is none. This is a suggestion from ChatGPT, but I'm not convinced it will help; let's see.
AlanRostem
added a commit
that referenced
this pull request
May 15, 2025
AlanRostem
added a commit
that referenced
this pull request
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
checkandcreateVotefunctionswhich do not have side effects and should be easier to test.