Rails 3.2 #71
Closed
Rails 3.2 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you know what differences are between citizenry and @alexknowshtml's and @cera's work in WeWorkIn*? |
|
@mchung It's just a fork from a previous point in time. We haven't had a chance to merge in the latest citizenry changes that were made in the past year. I hope to get to it eventually. |
|
Thanks @cera. Looks like a pretty good fork. Wish I had know about it earlier: I also did both herokuification and view-as-maps functionality on my own fork mchung/weworkinphx-citizenry. |
|
@mchung: Thanks. Can you send me a link to the view-as-maps functionality? I tried to find it on your PHX website. Here is the maps functionality we created: http://weworkinphilly.com/companies/map |
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over Xmas, I upgraded this app to use Rails-3.2. This pretty much involved touching everything: specs/new factories, new gems, new omniauth strategies, integrated compass w/ assets pipeline, etc.
I hope this pull request goes through. The twitter and omniauth rubygems were quite outdated making it almost impossible to setup new instances of Citizenry.
Best,