-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rehype-callouts
to list of plugins
#175
Conversation
Signed-off-by: 椰云拿铁 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 154 154
=========================================
Hits 154 154 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lin-stephanie!
This plugin looks really good.
It's great that testing, types, and lint checks area already in place.
Some subtle, non-blocking thoughts:
@types/hast
is included in the distributed/production types, it could be good to move it to adependency
(rather thendevDependency
) to ensure stricter package managers like yarn/pnpm are happy using it https://github.com/lin-stephanie/rehype-callouts/blob/a48cda574d01d6b931d954f93fec36e0517675d8/package.json#L53- It looks like publishing is done through a GitHub action, it could be good to include provenance information to allow adopters to trace the release back to a specific build https://github.blog/security/supply-chain-security/introducing-npm-package-provenance/, though it might take some tinkering to get that to work with
pnpm
Pnpm publish with provenance flag doesn't work pnpm/pnpm#6607
Thanks! |
This comment has been minimized.
This comment has been minimized.
Thanks for the merge @wooorm and suggestions @ChristianMurphy! I’ll consider them for the next update. |
Initial checklist
Description of changes
Added a new plugin
rehype-callouts
to list of plugins