-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add link to rehype remove images #145
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 461 461
=========================================
Hits 461 461 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks! ❤️
The readme contains some unresolved link references by the way. You may want to resolve those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I do still recommend using
unist-util-visit
, much more powerful! feat: rehype-remove-images rehype-minify#47 (review) - you don’t have to return
undefined
explicitly I guess? Don’t return anything is the same? - Looks like
index.d.ts
is generated, so perhaps you can omit it from the Git history
for me, it felt like this method was a bit more explicit / easier to understand. It's such a simple use case I figured it didn't matter much. Will look into this for the next one though! |
doc/plugins.md
Outdated
- [List of plugins](#list-of-plugins) | ||
- [List of utilities](#list-of-utilities) | ||
- [Use plugins](#use-plugins) | ||
- [Create plugins](#create-plugins) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run npm install
and npm test
, that should reformat everything according to project style, or undo these changes manually? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
Thanks! |
Initial checklist
Description of changes
adding link to new plugin
ref: rehypejs/rehype-minify#47