Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sandboxes to use vite and typescript #4

Merged

Conversation

ChristianMurphy
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

the native dependencies in parcel no longer work in browser sandboxes like stackblitz

https://stackblitz.com/github/ChristianMurphy/.github-rehype/tree/migrate-parcel-to-vite/sandbox-templates/rehype-debug
https://stackblitz.com/github/ChristianMurphy/.github-rehype/tree/migrate-parcel-to-vite/sandbox-templates/rehype-dom-debug

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 29, 2023
@ChristianMurphy ChristianMurphy added 🏗 area/tools This affects tooling 📚 area/docs This affects documentation labels Aug 29, 2023
@remcohaszing
Copy link
Member

Is there a particular reason to switch to TypeScript? I'm not against it, but most of the unified ecosystem uses JavaScript.

@ChristianMurphy
Copy link
Member Author

ChristianMurphy commented Aug 29, 2023

This is mirroring remarkjs/.github#9
The reason being

also run sandboxes through typescript to catch potential issues with plugin compatibility and options.


If your question is more towards TS syntax vs JSDoc syntax.
The reason is to more closely match what vite has setup by default.
These are not packages nor are they published to npm, they are sandboxes designed to roughly match what an average developer setup may look like.
If we want to push JSDoc for that as well, I'm happy to, but that may diverge a bit from a usual vite setup.

@remcohaszing
Copy link
Member

remcohaszing commented Aug 29, 2023

Personally I'm all for TS syntax, especially for code that's not run directly in Node.js.

@ChristianMurphy
Copy link
Member Author

Merging this in, as the current sandboxes are broken.
@rehypejs/maintainers if you have further thoughts and suggestions, feel free to add them, happy to discuss more and potentially add follow up PRs.

@ChristianMurphy ChristianMurphy merged commit 04feca2 into rehypejs:main Aug 30, 2023
3 checks passed
@ChristianMurphy ChristianMurphy deleted the migrate-parcel-to-vite branch August 30, 2023 16:42
@github-actions

This comment has been minimized.

@ChristianMurphy ChristianMurphy added the 💪 phase/solved Post is done label Aug 30, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 area/docs This affects documentation 🏗 area/tools This affects tooling 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

2 participants