Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace XzLibLzmaDevelMigrator with MiniReplacement #3851

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Mar 10, 2025

Description:

Introduce a MiniReplacement migrator that is a minimigrator based on Replacement, and replace the XzLibLzmaDevelMigrator with it. Extend to v1 recipes while at it.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

Discussed in #3360


@beckermr, could you do a quick initial review before I switch some more minimigrators over?

mgorny added 6 commits March 10, 2025 19:58
Introduce a `MiniReplacement` migrator that is a minimigrator based
on `Replacement`, and replace the `XzLibLzmaDevelMigrator` with it.
Extend to v1 recipes while at it.
Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! One comment on the host-only thing which we need.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 90.16393% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.86%. Comparing base (9c8cdb2) to head (020f4fe).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
conda_forge_tick/make_migrators.py 0.00% 3 Missing ⚠️
tests/test_minireplacement.py 91.17% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3851      +/-   ##
==========================================
- Coverage   78.39%   76.86%   -1.53%     
==========================================
  Files         138      133       -5     
  Lines       15194    15119      -75     
==========================================
- Hits        11911    11621     -290     
- Misses       3283     3498     +215     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This Pr is great and thank you!

@mgorny mgorny marked this pull request as ready for review March 12, 2025 07:54
@mgorny
Copy link
Contributor Author

mgorny commented Mar 12, 2025

I do wonder if we really ought to test minimigrators combined with version migrators — we're seeing a lot of flakiness here, and I think version migrators per se have quite a lot coverage already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants