-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace XzLibLzmaDevelMigrator
with MiniReplacement
#3851
base: main
Are you sure you want to change the base?
Conversation
Introduce a `MiniReplacement` migrator that is a minimigrator based on `Replacement`, and replace the `XzLibLzmaDevelMigrator` with it. Extend to v1 recipes while at it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! One comment on the host-only thing which we need.
It uses the same logic as the xz/lzma-devel migrator.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3851 +/- ##
==========================================
- Coverage 78.39% 76.86% -1.53%
==========================================
Files 138 133 -5
Lines 15194 15119 -75
==========================================
- Hits 11911 11621 -290
- Misses 3283 3498 +215 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This Pr is great and thank you!
I do wonder if we really ought to test minimigrators combined with version migrators — we're seeing a lot of flakiness here, and I think version migrators per se have quite a lot coverage already. |
Description:
Introduce a
MiniReplacement
migrator that is a minimigrator based onReplacement
, and replace theXzLibLzmaDevelMigrator
with it. Extend to v1 recipes while at it.Checklist:
Cross-refs, links to issues, etc:
Discussed in #3360
@beckermr, could you do a quick initial review before I switch some more minimigrators over?