-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support local running of "conda-forge-tick --dry-run auto-tick" #3680
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3680 +/- ##
==========================================
- Coverage 77.36% 75.72% -1.65%
==========================================
Files 134 134
Lines 14814 14825 +11
==========================================
- Hits 11461 11226 -235
- Misses 3353 3599 +246 ☔ View full report in Codecov by Sentry. |
Thank you! Let me reference #2815 here, which also adds selecting migrators for auto-tick (but is blocked by outstanding reviews) |
Yeah I have been slow to review here sorry. Why is one PR so much bigger than the other? This one is tiny and very easy to review. |
My PR is outdated and eventually builds upon this one: #2813 (which is very short and also includes tests). The line changes come from the linked PR in between (#2814) which allows to run make-migrators (which is needed for auto-tick) locally too. If you want to review #2813 (to start clearing up the backlog), I can update it. Was waiting for a review on the integration tests first. (because they also secure these changes) |
2f10994
to
644c7c7
Compare
What's the prefered plan here? Should I finish this up with tests or shall we go with #2815? |
Thanks for the pr. Let's merge as is and we can combine with other prs later. |
Description:
Add support for running the
auto-tick
command locally.I also added the option to passing a regex to only run the migrators which are of interest as well as a
--no-update-graph
to make debugging faster.If you'd rather not have this PR merged, I don't mind if it's closed, 95% of the work was needed for debugging something else 😄
Checklist:
Cross-refs, links to issues, etc: