Patch: Fix Index Resetting on Removal #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 16, 2024
johnnyshankman
force-pushed
the
johnny/fix-index-on-remove-error
branch
from
268d3cd to
978ac27
Compare
johnnyshankman
commented
Nov 16, 2024
| @@ -331,7 +331,7 @@ declare class Gapless5Source { | |||
| isPlayActive: (checkStarting: any) => boolean; | |||
| getPosition: () => number; | |||
| getLength: () => number; | |||
| play: (syncPosition: any) => void; | |||
| play: (syncPosition: any, skipCallback: any) => void; | |||
There was a problem hiding this comment.
Note: I reran the type generator and this just appeared.
johnnyshankman
force-pushed
the
johnny/fix-index-on-remove-error
branch
from
0b61edc to
da8eb36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This fixes a bug causing the index/trackNumber of the currently playing song to be incorrect after calling
removeTrack(orreplaceTrackwhich defers toremoveTrack)Maintains error logging when the index requested is out of bounds, and maintains that it returns early in that case.
Found while developing this PR on my music app hihat
Reproduction of Issue
getIndex()now returns01getIndex()now returns12getIndexnow returns0instead of1This causes the currently playing song to do weird things, like pausing and start returning the wrong song info.
QA
The new unit tests which regression test this behavior are passing.