Login page #26
Open
Login page #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to outgoing requests
| fa-icon "key" | ||
| = input class='form-control' value=password placeholder='Your Password' type='password' | ||
| .row.login-links | ||
| .col-xs-3.col-sm-2.col-md-1 |
There was a problem hiding this comment.
I'd make the buttons equally large and take the whole width on a mobile screen for consistency and and fat fingers 😉 . col-xs-3 col-sm-3 col-md-2 and changing the button width to 100%.
|
Great! Please use locale strings instead of English words. |
|
okay I've done everything you mentioned... but I'm not really able to add locale strings as placeholder for the inputs... do you have an idea? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds possibility for users to login locally. Uses the oauth integration in the backend as described by
this PR.
It might need some more test but I'm not sure what kind of tests... I just have such a feeling ;)