Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace): Add website favicon support for resource cards #441

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

pftom
Copy link
Contributor

@pftom pftom commented Feb 2, 2025

  • Implement dynamic favicon fetching for resources with URLs
  • Add fallback icon rendering using SVG when favicon fails to load
  • Use Google's favicon service for retrieving website icons
  • Enhance resource card visual representation with website-specific icons

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Impact Areas

Please check the areas this PR affects:

  • Multi-threaded Dialogues
  • AI-Powered Capabilities (Web Search, Knowledge Base Search, Question Recommendations)
  • Context Memory & References
  • Knowledge Base Integration & RAG
  • Quotes & Citations
  • AI Document Editing & WYSIWYG
  • Free-form Canvas Interface
  • Other

Screenshots/Videos

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Refly Documentation
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

pftom added 2 commits February 2, 2025 21:44
- Implement dynamic favicon fetching for resources with URLs
- Add fallback icon rendering using SVG when favicon fails to load
- Use Google's favicon service for retrieving website icons
- Enhance resource card visual representation with website-specific icons
@pftom pftom merged commit 903f431 into main Feb 2, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants