Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android w/ ghc 8.10 #782

Draft
wants to merge 52 commits into
base: develop
Choose a base branch
from
Draft

android w/ ghc 8.10 #782

wants to merge 52 commits into from

Conversation

plt-amy
Copy link
Contributor

@plt-amy plt-amy commented Jun 6, 2022

just need a cheap & easy CI run

default.nix Outdated
@@ -1,6 +1,6 @@
{ nixpkgsFunc ? import ./nixpkgs
, system ? builtins.currentSystem
, config ? {}
, config ? { android_sdk.accept_license = true; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not, but it was there when i got here

@chrbauer
Copy link
Contributor

Overwriting the original Java sources, is exactly what I need. It worked immediately with this branch. well done.

@chrbauer
Copy link
Contributor

Currently it is not possible to upload an app to the google play store:
"Your app currently targets API level 29 and must target at least API level 30 to ensure it is built on the latest APIs optimized for security and performance. Change your app's target API level to at least 30"

I think it is not trivial to increase the android platform version to 30.

ali-abrar added 16 commits July 13, 2022 10:06
There are changes in upstream's ghc-8.10 that aren't part of ghc-8.10.7
and this causes the nixpkgs to fail (because it tries to apply patches
that have since been upstreamed)
…-8_10-wip

* origin/nixpkgs-21.05:
  android: Update ghc thunk to one that actually includes splices
…-8_10-wip

* origin/nixpkgs-21.05:
  android: sdk version 30
@chrbauer
Copy link
Contributor

I overlooked, that in this MR some similar changes were done as in nixpkgs-22.05 , e.g. the gradle upgrade. How can we combine our efforts?

@ali-abrar
Copy link
Member

@mankyKitty is this already included in the v1 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants