Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rich progress bar to tqdm progress bar #3514

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

TG199
Copy link
Contributor

@TG199 TG199 commented Jun 18, 2024

All Submissions:

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

This commit replaces the Rich progress bar implementation with TQDM #3487. The following changes were made:

  • Replaced Rich Progress Bar:

    • Updated the _zip function to use TQDM for progress bar handling.
    • TQDM is now responsible for displaying progress during zipping operations, providing a simpler and lighter alternative to Rich.
  • Preserved Pretty Printing with Rich:

    • Retained the use of rich.console for pretty printing logs and outputs to maintain readability and formatting in the console.
  • Updated Dependencies:

    • Added TQDM to pyproject.toml as a dependency.

Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to poetry lock again for the tests

@TG199
Copy link
Contributor Author

TG199 commented Jun 25, 2024

Okay

@masenf
Copy link
Collaborator

masenf commented Jun 28, 2024

i pushed a fix for the merge conflict here... but i think there are some other issues we need to resolve here before we can take this change.

  1. update the dependency review CI job to accept the MIT / APL-2.0 license... unfortunately these combo licenses need to all be added in the workflow
  2. this adds a new dependency but doesn't actually remove the rich dependency as specified by Removing Rich #3487

i'm hesitant to take the new dep without fully removing the old dep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants