Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic changes for image presenter #3489

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Basic changes for image presenter #3489

wants to merge 4 commits into from

Commits on Oct 18, 2021

  1. Basic changes for image presenter 

    . ensure markup is identical for each view as far as possible
. Use css-grid to prevent image title/file name overwriting icons
. Add locale markers to images in grid view
    @anitagraham
    anitagraham committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    db0f9d5 View commit details
    Browse the repository at this point in the history

  2. Change github actions/workflow to use ruby/setup-ruby. actions/setup_… 

    …ruby is deprecated

Merge imagePresenter and collectionPresenter.
Tests pass.
    @anitagraham
    anitagraham committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    821bfd9 View commit details
    Browse the repository at this point in the history

  3. Use safe navigation when getting titles

    @anitagraham
    anitagraham committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    820b1b9 View commit details
    Browse the repository at this point in the history

  4. Reflect suggestions and changes from refinery/master

    @anitagraham
    anitagraham committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    3ff1360 View commit details
    Browse the repository at this point in the history