Skip to content

Commit

Permalink
fix(types): remove path aliases from type imports (#6683)
Browse files Browse the repository at this point in the history
  • Loading branch information
aliemir authored Feb 18, 2025
1 parent 989b438 commit a12a082
Show file tree
Hide file tree
Showing 20 changed files with 44 additions and 25 deletions.
15 changes: 15 additions & 0 deletions .changeset/itchy-peas-pump.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
"@refinedev/mantine": patch
"@refinedev/antd": patch
"@refinedev/core": patch
"@refinedev/kbar": patch
"@refinedev/cli": patch
---

fix(types): remove path aliases from type imports

Since typescript doesn't resolve and replace path aliases, using them for the type imports will cause `d.ts` files to reference unresolvable paths and types.

While this doesn't break everything, it breaks the types in places where the path aliases are used for type imports.

This change removes the path aliases from the type imports and replaces them with relative imports.
2 changes: 1 addition & 1 deletion packages/antd/src/definitions/filter-mappers/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type {
FilterDropdownProps,
MapValueEvent,
} from "@components/table/components";
} from "../../components/table/components";
import dayjs from "dayjs";

/**
Expand Down
4 changes: 2 additions & 2 deletions packages/antd/src/hooks/useThemedLayoutContext/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useContext } from "react";

import { ThemedLayoutContext } from "@contexts";
import type { IThemedLayoutContext } from "@contexts/themedLayoutContext/IThemedLayoutContext";
import { ThemedLayoutContext } from "../../contexts";
import type { IThemedLayoutContext } from "../../contexts/themedLayoutContext/IThemedLayoutContext";

export type UseThemedLayoutContextType = IThemedLayoutContext;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { ProjectTypes } from "@definitions/projectTypes";
import type { ProjectTypes } from "../../../../../definitions/projectTypes";
import { AntDesignIntegration } from "./ant-design";
import { ReactRouterIntegration } from "./react-router";

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/commands/check-updates/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import spinner from "@utils/spinner";
import type {
NpmOutdatedResponse,
RefinePackageInstalledVersionData,
} from "@definitions/package";
} from "../../definitions/package";
import semverDiff from "semver-diff";
import { maxSatisfying } from "semver";

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/commands/update/interactive/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { parsePackageNameAndVersion } from "@utils/package";
import type {
PackageDependency,
RefinePackageInstalledVersionData,
} from "@definitions/package";
} from "../../../definitions/package";

type UIGroup = {
patch: {
Expand Down
10 changes: 7 additions & 3 deletions packages/cli/src/components/update-warning-table/table.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
import type { RefinePackageInstalledVersionData } from "@definitions/package";
import type { RefinePackageInstalledVersionData } from "../../definitions/package";
import chalk from "chalk";
import center from "center-align";
import { getDependencies, getPreferedPM, getScripts } from "@utils/package";
import { getVersionTable } from "@components/version-table";
import {
getDependencies,
getPreferedPM,
getScripts,
} from "../../utils/package";
import { getVersionTable } from "../version-table";

export interface UpdateWarningTableParams {
data: RefinePackageInstalledVersionData[];
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/components/version-table/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { RefinePackageInstalledVersionData } from "@definitions/package";
import type { RefinePackageInstalledVersionData } from "../../definitions/package";
import Table from "cli-table3";
import chalk from "chalk";
import { removeANSIColors } from "@utils/text";
Expand Down
4 changes: 2 additions & 2 deletions packages/cli/src/telemetry/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { NODE_ENV } from "@definitions/node";
import type { ProjectTypes } from "@definitions/projectTypes";
import type { NODE_ENV } from "../definitions/node";
import type { ProjectTypes } from "../definitions/projectTypes";
import { ENV } from "@utils/env";
import { getOS } from "@utils/os";
import { getInstalledRefinePackages, getRefineProjectId } from "@utils/package";
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/update-notifier/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import Conf from "conf";
import chalk from "chalk";
import { isRefineUptoDate } from "@commands/check-updates";
import { printUpdateWarningTable } from "@components/update-warning-table";
import type { RefinePackageInstalledVersionData } from "@definitions/package";
import type { RefinePackageInstalledVersionData } from "../definitions/package";
import { getInstalledRefinePackages } from "@utils/package";
import { ENV } from "@utils/env";
import { stringToBase64 } from "@utils/encode";
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/utils/announcement/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from "react";
import matter from "gray-matter";
import boxen from "boxen";

import type { Announcement } from "@definitions/announcement";
import type { Announcement } from "../../definitions/announcement";
import { markedTerminalRenderer } from "@utils/marked-terminal-renderer";

const ANNOUNCEMENT_URL =
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/utils/env/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { NODE_ENV } from "@definitions/node";
import type { NODE_ENV } from "../../definitions/node";
import * as dotenv from "dotenv";

const refineEnv: Record<string, string> = {};
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/utils/package/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { existsSync, pathExists, readFileSync, readJSON } from "fs-extra";
import globby from "globby";
import path from "path";
import preferredPM from "preferred-pm";
import type { PackageJson } from "@definitions/package";
import type { PackageJson } from "../../definitions/package";

export const getPackageJson = (): PackageJson => {
if (!existsSync("package.json")) {
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/utils/project/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ProjectTypes, UIFrameworks } from "@definitions";
import { ProjectTypes, UIFrameworks } from "../../definitions";
import { getDependencies, getDevDependencies } from "@utils/package";

export const getProjectType = (platform?: ProjectTypes): ProjectTypes => {
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/utils/resource/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ProjectTypes } from "@definitions/projectTypes";
import { ProjectTypes } from "../../definitions/projectTypes";
import camelCase from "camelcase";

export const getResourcePath = (
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/utils/swizzle/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import path from "path";
import type { RefineConfig } from "@definitions";
import type { RefineConfig } from "../../definitions";
import { provideCliHelpers } from "./provideCliHelpers";

export const getRefineConfig = async (
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { useTranslate } from "@hooks/i18n";
import type { useTranslate } from "../../../hooks/i18n";

import type { IResourceItem } from "../../../contexts/resource/types";
import { safeTranslate } from "../safe-translate";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { useTranslate } from "@hooks/i18n";
import type { useTranslate } from "../../../hooks/i18n";

export const safeTranslate = (
translate: ReturnType<typeof useTranslate>,
Expand Down
4 changes: 2 additions & 2 deletions packages/kbar/src/components/refineKbar/index.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import React, { useContext } from "react";

import { RefineKbarPropsContext } from "./../../index";
import { useRefineKbar } from "@hooks";
import { CommandBar } from "@components";
import { useRefineKbar } from "../../hooks";
import { CommandBar } from "../";

export const RefineKbar: React.FC<{
commandBarProps?: React.ComponentProps<typeof CommandBar>;
Expand Down
4 changes: 2 additions & 2 deletions packages/mantine/src/hooks/useThemedLayoutContext/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useContext } from "react";

import { ThemedLayoutContext } from "@contexts";
import type { IThemedLayoutContext } from "@contexts/themedLayoutContext/IThemedLayoutContext";
import { ThemedLayoutContext } from "../../contexts";
import type { IThemedLayoutContext } from "../../contexts/themedLayoutContext/IThemedLayoutContext";

export type UseThemedLayoutContextType = IThemedLayoutContext;

Expand Down

0 comments on commit a12a082

Please sign in to comment.