Raise exception for invalid s3 credentials#24
Closed
sobrinho wants to merge 1 commit into
Closed
Conversation
Member
Author
|
@jnicklas see if that's the way to go. Basically we need better error messages due to typos instead of strange exceptions. Does makes sense? |
|
AWS credentials as options should be actually considered optional (see other pull requests like #29 #18. Recommended on EC2 is actually instance profiles. See also AWS SDK configuration. |
Member
Author
|
So, maybe in that case we could create a special value like What you suggest? We must have better exception messages. |
|
Doesn't AWS SDK already raise exceptions for missing configuration? |
Member
Author
|
Not sure but on refile/refile#454 you will see that the error appears on refile itself, not on SDK. |
Member
Author
|
Closing, if we found a better way to do that, a new pull request will be done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See refile/refile#454