Skip to content

Raise exception for invalid s3 credentials#24

Closed
sobrinho wants to merge 1 commit into
refile:masterfrom
sobrinho:master
Closed

Raise exception for invalid s3 credentials#24
sobrinho wants to merge 1 commit into
refile:masterfrom
sobrinho:master

Conversation

@sobrinho

@sobrinho sobrinho commented May 26, 2016

Copy link
Copy Markdown
Member

@sobrinho

Copy link
Copy Markdown
Member Author

@jnicklas see if that's the way to go.

Basically we need better error messages due to typos instead of strange exceptions.

Does makes sense?

@klausbadelt

Copy link
Copy Markdown

AWS credentials as options should be actually considered optional (see other pull requests like #29 #18. Recommended on EC2 is actually instance profiles. See also AWS SDK configuration.

@sobrinho

sobrinho commented Oct 2, 2016

Copy link
Copy Markdown
Member Author

So, maybe in that case we could create a special value like Refile::S3::NO_VALUE, I don't know.

What you suggest?

We must have better exception messages.

@filmhubhq

Copy link
Copy Markdown

Doesn't AWS SDK already raise exceptions for missing configuration?

@sobrinho

Copy link
Copy Markdown
Member Author

Not sure but on refile/refile#454 you will see that the error appears on refile itself, not on SDK.

@sobrinho

Copy link
Copy Markdown
Member Author

Closing, if we found a better way to do that, a new pull request will be done.

@sobrinho sobrinho closed this Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants