Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analog Input Update #3

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Analog Input Update #3

wants to merge 6 commits into from

Conversation

Sral931
Copy link

@Sral931 Sral931 commented Jan 6, 2023

Implemented features as described on Reef2Reef.com:

  • FlowMeter compatibility
  • Robo-Tank PH circuit compatibility
  • extended AnalogInput ID handling
    As well as other improvements:
  • improved DRYness of the code
  • extended the Debug messages on the Serial Port
    Noted Problems:
  • sometimes AnalogInputQuerries register as id:0 even though no such request was set in ReefPi
  • this indicates a possible problem with AsyncTCP communication
  • backlog from crashes indicate that AsyncTCP is "at fault" or not perfectly compatible
  • crash frequency seems to increase with active flowmeter interrupts
  • possibly due to a conflict wit AsyncTCP, if that also uses interrupts for communication

Sral931 added 6 commits January 6, 2023 16:38
@Sral931
Create .gitignore and Update reef-pi.ino
962c12e 
Ignore Arduino secondary files

Update reef-pi.ino:
Improved DRYness
Extended Debug Messages
Included flowmeter compatibility
Included robo-tank pH compatibility
Included multiple DS18B20 sensors
Improved AnalogInput handling

Update reef-pi.ino

Improved DRYness
Extended Debug Messages
Included flowmeter compatibility
Included robo-tank pH compatibility
Included multiple DS18B20 sensors
Improved AnalogInput handling
@Sral931
Restructured Startup + Flowmeter Bugfix
a35aed9
@Sral931
Volatile Counter
5d026ad
@Sral931
Revert "Volatile Counter"
3b0ad70 
This reverts commit 5d026ad.
@Sral931
Reduced Flowmeters to 1
07659e0 
Multiple flowmeters without volatile variable can be found in an earlier commit
@Sral931
Delete Backtraces.txt
0a979aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sral931