Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): improve exit story block edit mode #1347

Merged
merged 20 commits into from
Jan 23, 2025
Merged

refactor(web): improve exit story block edit mode #1347

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
55f4cf7
exit editor mode on page change
mkumbobeaty Jan 13, 2025
186c223
Merge branch 'main' of github.com:reearth/reearth-visualizer into cho…
mkumbobeaty Jan 13, 2025
dc36ab0
adjust page-gap height
mkumbobeaty Jan 14, 2025
91c7aa5
Merge branch 'main' of github.com:reearth/reearth-visualizer into cho…
mkumbobeaty Jan 14, 2025
53498ea
add default page gap
mkumbobeaty Jan 15, 2025
5d43e35
Merge branch 'main' of github.com:reearth/reearth-visualizer into cho…
mkumbobeaty Jan 15, 2025
223947f
revert changes
mkumbobeaty Jan 15, 2025
6c855f1
remove page gape
mkumbobeaty Jan 15, 2025
7cd8d2b
merge from main
mkumbobeaty Jan 16, 2025
ded3b88
Merge branch 'main' of github.com:reearth/reearth-visualizer into cho…
mkumbobeaty Jan 16, 2025
4aaf8fd
undo server changes
mkumbobeaty Jan 16, 2025
54a8095
undo server changes
mkumbobeaty Jan 16, 2025
2a3758d
refactor: revert changes on server
airslice Jan 16, 2025
61e419c
format config file
mkumbobeaty Jan 16, 2025
c735622
improve height
mkumbobeaty Jan 20, 2025
bff9449
Merge branch 'main' of github.com:reearth/reearth-visualizer into cho…
mkumbobeaty Jan 20, 2025
3e5b8dc
Merge branch 'chore/story-blockexit-mode' of github.com:reearth/reear…
mkumbobeaty Jan 20, 2025
7464ad3
reset changes
mkumbobeaty Jan 22, 2025
96c5d03
Merge branch 'main' of github.com:reearth/reearth-visualizer into cho…
mkumbobeaty Jan 22, 2025
e886f50
Merge branch 'main' of github.com:reearth/reearth-visualizer into cho…
mkumbobeaty Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/src/beta/features/Visualizer/Crust/StoryPanel/PanelContent/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export default ({
const pageWrapperElement = document.getElementById(
STORY_PANEL_CONTENT_ELEMENT_ID
);
if (pageWrapperElement) setPageGap(pageWrapperElement.clientHeight - 40); // 40px is the height of the page title block
if (pageWrapperElement) setPageGap(pageWrapperElement.clientHeight - 90); // 90px is the height of the page title block
airslice marked this conversation as resolved.
Show resolved Hide resolved
}, [setPageGap]);

useEffect(() => {
Expand Down
5 changes: 5 additions & 0 deletions web/src/beta/features/Visualizer/Crust/StoryPanel/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ export default (
onStoryPageChange?.(newPage.id);
setCurrentPageId(newPage.id);
setLayerOverride(undefined);
if (disableSelection) {
setDisableSelection(false);
setSelectedBlockId(undefined);
}

const container = document.getElementById(STORY_PANEL_CONTENT_ELEMENT_ID);
if (!pageId) {
Expand Down Expand Up @@ -163,6 +167,7 @@ export default (
currentPageId,
selectedStory?.pages,
onStoryPageChange,
disableSelection,
handlePageTime,
visualizer
]
Expand Down
Loading