Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): correct validation behavior when handling invalid values #1225

Merged
merged 17 commits into from
Oct 7, 2024

Conversation

caichi-t
Copy link
Contributor

Overview

This PR fixes the behavior when setting validation and some invalid value is present on Text, TextArea, Markdown text, Int, and Geometry fields.

Memo

This PR includes a small translation fix.

Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for reearth-cms ready!

Name Link
🔨 Latest commit d9ca83c
🔍 Latest deploy log https://app.netlify.com/sites/reearth-cms/deploys/6703a263af498d000843ed0d
😎 Deploy Preview https://deploy-preview-1225--reearth-cms.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Sep 10, 2024
@nourbalaha nourbalaha changed the title fix(web): the behavior when setting validation and some invalid value is present fix(web): correct validation behavior when handling invalid values Sep 27, 2024
@caichi-t caichi-t requested a review from nourbalaha October 4, 2024 09:38
@caichi-t caichi-t enabled auto-merge (squash) October 7, 2024 08:57
@caichi-t caichi-t merged commit 477da7f into main Oct 7, 2024
6 checks passed
@caichi-t caichi-t deleted the fix-web/improve-ux branch October 7, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants