Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(setup): list @redwoodjs/cli-helpers as dependency to @redwoodjs/cli #7141

Merged
merged 1 commit into from
Dec 14, 2022
Merged

fix(setup): list @redwoodjs/cli-helpers as dependency to @redwoodjs/cli #7141

merged 1 commit into from
Dec 14, 2022

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Dec 13, 2022

#7138, which removed @redwoodjs/cli's dependency on @redwoodjs/auth-providers-setup, revealed a hidden dependency on @redwoodjs/cli-helpers introduced in #6082. This PR lists it explicitly. Otherwise you get this in Redwood projects when trying to run yarn rw setup anything:

# Wall of text that seems to be literally all of yargs source code or something
# ...

Error: Cannot find module '@redwoodjs/cli-helpers'
Require stack:
- /Users/dom/prjcts/redwood/redwood-app/node_modules/@redwoodjs/cli/dist/commands/setup/cache/cache.js
- /Users/dom/prjcts/redwood/redwood-app/node_modules/yargs/build/index.cjs
- /Users/dom/prjcts/redwood/redwood-app/node_modules/yargs/helpers/index.js
- /Users/dom/prjcts/redwood/redwood-app/node_modules/@redwoodjs/cli/dist/index.js
- /Users/dom/prjcts/redwood/redwood-app/node_modules/@redwoodjs/cli/package.json
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:956:15)
    at Function.Module._load (node:internal/modules/cjs/loader:804:27)
    at Module.require (node:internal/modules/cjs/loader:1028:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/Users/dom/prjcts/redwood/redwood-app/node_modules/@redwoodjs/cli/dist/commands/setup/cache/cache.js:14:19)
    at Module._compile (node:internal/modules/cjs/loader:1126:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1180:10)
    at Module.load (node:internal/modules/cjs/loader:1004:32)
    at Function.Module._load (node:internal/modules/cjs/loader:839:12)
    at Module.require (node:internal/modules/cjs/loader:1028:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/dom/prjcts/redwood/redwood-app/node_modules/@redwoodjs/cli/dist/commands/setup/cache/cache.js',
    '/Users/dom/prjcts/redwood/redwood-app/node_modules/yargs/build/index.cjs',
    '/Users/dom/prjcts/redwood/redwood-app/node_modules/yargs/helpers/index.js',
    '/Users/dom/prjcts/redwood/redwood-app/node_modules/@redwoodjs/cli/dist/index.js',
    '/Users/dom/prjcts/redwood/redwood-app/node_modules/@redwoodjs/cli/package.json'
  ]
}

@jtoar jtoar added release:fix This PR is a fix fixture-ok Override the test project fixture check labels Dec 13, 2022
@jtoar jtoar self-assigned this Dec 13, 2022
@jtoar jtoar changed the title fix: add cli-helpers as dep fix(setup): list @redwoodjs/cli-helpers as dependency to @redwoodjs/cli Dec 13, 2022
@jtoar jtoar merged commit 9267c04 into main Dec 14, 2022
@jtoar jtoar deleted the ds-fix-yarn-rw-setup branch December 14, 2022 00:08
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Dec 14, 2022
@redwoodjs-bot
Copy link

redwoodjs-bot bot commented Dec 14, 2022

🔔 @jtoar, @Tobbe—I couldn't cherry pick this one. If you want it in the next release, you'll have to cherry pick it manually.

dac09 added a commit that referenced this pull request Dec 14, 2022
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into feat/dc-kc-e…
f071045 
…xperimental-vite-optin

* 'main' of github.com:redwoodjs/redwood: (27 commits)
  fix(deps): update dependency @types/node to v16.18.9 (#7140)
  fix(deps): update dependency vscode-languageserver-textdocument to v1.0.8 (#7132)
  fix: add cli-helpers as dep (#7141)
  remove deprecated auth providers (#7138)
  chore: update test project fixture dbauth packages (#7139)
  NavLink not highlighting when on sub pages (#6939)
  Rename create auth functions (#7137)
  Export underlying cache client with Service Cache functions (#7062)
  fix(deps): update dependency @simplewebauthn/browser to v6.2.2 (#7103)
  fix(deps): update dependency msw to v0.49.2 (#7126)
  chore(deps): update dependency nx to v15.3.3 (#7125)
  fix(deps): update docusaurus monorepo to v2.2.0 (#7116)
  [docs] How to test in GitHub actions (#6921)
  fix(deps): update typescript-eslint monorepo to v5.46.1 (#7109)
  Codemod to include full-name in test-project signup (#7124)
  Rebuild test-project fixture (#7123)
  feat: add CustomValidator (#7051)
  dbAuthClient (#7111)
  chore(deps): update dependency nx to v15.3.2 (#7114)
  chore(deps): update dependency redis to v4.5.1 (#7115)
  ...
@jtoar jtoar modified the milestones: next-release, v4.0.0 Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jtoar jtoar

Labels
fixture-ok Override the test project fixture check release:fix This PR is a fix
Projects
Main
Status: Done
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jtoar