-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router): Skip search params with undefined and null values passed to named routes #11635
fix(router): Skip search params with undefined and null values passed to named routes #11635
Conversation
I noticed it wasn't included in the 8.4.0 release, does it need anything else? |
@Josh-Walker-GM sorry for tagging you, just want to make sure we have a chance to resolve any issues before next release |
Hey @antonmoiseev! No worries about the pinging. Thanks for making sure this doesn't slip out of our memory! I think some others on the team wanted to just double/sanity check this but we've all been bogged down with other work so this has slipped. Sorry about that, we really do appreciate the contributions and the team has mentioned a number of times that we're grateful for your involvement in-particular. I'll see if I can get someone to look at this pr this week/next. -- Would you be able to update the description to provide a bit more context around the change, what it is, why it was needed etc? |
@Tobbe @antonmoiseev with this merged, i think #11598 can be closed now 🚀 |
Automatically ignoring null and undefined values for search params helps avoiding repetitive and verbose checks when calling
navigate()
function.Examples:
redirectTo
parameter in case of multi-step (multi-page) sign in / sign up process:In both examples parameters are optional and may be missing. Currently we have to manually filter out undefined and null values before passing them to generated route functions.