Skip to content

Commit

Permalink
Version docs to 8.4
Browse files Browse the repository at this point in the history
  • Loading branch information
Tobbe committed Dec 25, 2024
1 parent c84c39f commit ab69db7
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/versioned_docs/version-8.4/cli-commands.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ We use [yargs](http://yargs.js.org/) and borrow its syntax here:
yarn redwood generate page <name> [path] --option
```

- `redwood g page` is the command.
- `redwood generate page` is the command.
- `<name>` and `[path]` are positional arguments.
- `<>` denotes a required argument.
- `[]` denotes an optional argument.
Expand Down
5 changes: 4 additions & 1 deletion docs/versioned_docs/version-8.4/how-to/oauth.md
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,8 @@ Don't forget the new `CryptoJS` import at the top!
```js title="/api/src/functions/oauth/oauth.js"
// highlight-next-line
import CryptoJS from 'crypto-js'
import { cookieName } from '@redwoodjs/auth-dbauth-api'
import { cookieName as cookie } from 'src/lib/auth'

const callback = async (event) => {
const { code } = event.queryStringParameters
Expand Down Expand Up @@ -643,7 +645,8 @@ const secureCookie = (user) => {
data,
process.env.SESSION_SECRET
).toString()

//if you're using dbAuth v7.6.2, you have to change the cookie name. You can comment out the line below and make the next line as comment.
//return [`${cookieName(cookie)}=${encrypted}`, ...cookieAttrs].join('; ')
return [`session=${encrypted}`, ...cookieAttrs].join('; ')
}
// highlight-end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ const signupOptions = {
// ...
```
The signup page itself is still visible, however. To remove it completely, remove the `<Route>` in the Router, and remove the "Don't have an acocunt? Sign up!" link on the login page.
The signup page itself is still visible, however. To remove it completely, remove the `<Route>` in the Router, and remove the "Don't have an account? Sign up!" link on the login page.
Be sure to save your changes, then run `grove deploy` to push the changes live. Take that, hackers!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Note that the summary on the bottom indicates that there was 1 test that failed.

If you continued with your own repo from chapters 1-4, you may see some other failures here or none at all: we made a lot of changes to the pages, components and cells we generated, but didn't update the tests to reflect the changes we made. (Another reason to start with the [example repo](../intermission.md#using-the-example-repo-recommended)!)

To switch back to the default mode where test are **o**nly run for changed files, press `o` now (or quit and restart `yarn rw test`).
To switch back to the default mode where test are **only** run for changed files, press `o` now (or quit and restart `yarn rw test`).

What we want to aim for is all green in that left column and no failed tests. In fact best practices tell us you should not even commit any code to your repo unless the test suite passes locally. Not everyone adheres to this policy quite as strictly as others..._&lt;cough, cough&gt;_

Expand Down

0 comments on commit ab69db7

Please sign in to comment.